From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Scott Feldman <sfeldma@gmail.com>
Subject: Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops
Date: Wed, 6 Apr 2016 18:19:45 +0200 [thread overview]
Message-ID: <20160406161945.GA13088@lunn.ch> (raw)
In-Reply-To: <1459958105-1090-1-git-send-email-vivien.didelot@savoirfairelinux.com>
On Wed, Apr 06, 2016 at 11:55:02AM -0400, Vivien Didelot wrote:
> Neither the DSA layer nor the bridge code (see br_set_state) really care
> about eventual errors from STP state setters, so make it void.
>
> The DSA layer separates the prepare and commit phases of switchdev in
> two different functions. Logical errors must not happen in commit
> routines, so make them void.
Looks good.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
next prev parent reply other threads:[~2016-04-06 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 15:55 [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops Vivien Didelot
2016-04-06 15:55 ` [PATCH net-next v2 1/3] net: dsa: make the STP state function return void Vivien Didelot
2016-04-06 15:55 ` [PATCH net-next v2 2/3] net: dsa: make the FDB add " Vivien Didelot
2016-04-06 15:55 ` [PATCH net-next v2 3/3] net: dsa: make the VLAN " Vivien Didelot
2016-04-06 16:19 ` Andrew Lunn [this message]
2016-04-06 20:27 ` [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops Florian Fainelli
2016-04-08 20:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406161945.GA13088@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).