From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.
Date: Thu, 07 Apr 2016 13:38:43 -0400 (EDT) [thread overview]
Message-ID: <20160407.133843.156901424652264502.davem@davemloft.net> (raw)
In-Reply-To: <1460046677.6715.95.camel@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 07 Apr 2016 09:31:17 -0700
> On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote:
>> Disable a debugging statement that has been left enabled
>>
>> Signed-off-by: David Howells <dhowells@redhat.com>
>> ---
>>
>> net/rxrpc/ar-ack.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c
>> index 16d967075eaf..01a017a05f14 100644
>> --- a/net/rxrpc/ar-ack.c
>> +++ b/net/rxrpc/ar-ack.c
>> @@ -426,7 +426,7 @@ static void rxrpc_rotate_tx_window(struct rxrpc_call *call, u32 hard)
>> int tail = call->acks_tail, old_tail;
>> int win = CIRC_CNT(call->acks_head, tail, call->acks_winsz);
>>
>> - kenter("{%u,%u},%u", call->acks_hard, win, hard);
>> + _enter("{%u,%u},%u", call->acks_hard, win, hard);
>>
>> ASSERTCMP(hard - call->acks_hard, <=, win);
>
> It might be better to remove kenter and _enter
> altogether and use function tracing instead.
Yeah this custom stuff is really inappropriate given the excellent
infrastructure we have these days...
next prev parent reply other threads:[~2016-04-07 17:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:22 [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells
2016-04-07 16:23 ` [PATCH 1/9] afs: Wait for outstanding async calls before closing rxrpc socket David Howells
2016-04-07 16:23 ` [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled David Howells
2016-04-07 16:31 ` Joe Perches
2016-04-07 17:38 ` David Miller [this message]
2016-04-07 19:45 ` David Howells
2016-04-07 20:36 ` David Miller
2016-04-07 20:47 ` David Howells
2016-04-07 20:50 ` David Miller
2016-04-07 21:24 ` David Howells
2016-04-07 17:05 ` David Howells
2016-04-07 17:19 ` Joe Perches
2016-04-07 19:43 ` David Howells
2016-04-07 20:21 ` Joe Perches
2016-04-07 20:42 ` David Howells
2016-04-07 16:23 ` [PATCH 3/9] rxrpc: Move some miscellaneous bits out into their own file David Howells
2016-04-07 16:23 ` [PATCH 4/9] rxrpc: Static arrays of strings should be const char *const[] David Howells
2016-04-07 16:23 ` [PATCH 5/9] rxrpc: Differentiate local and remote abort codes in structs David Howells
2016-04-07 16:23 ` [PATCH 6/9] rxrpc: Don't pass gfp around in incoming call handling functions David Howells
2016-04-07 16:23 ` [PATCH 7/9] rxrpc: Don't assume transport address family and size when using it David Howells
2016-04-07 16:23 ` [PATCH 8/9] rxrpc: Absorb the rxkad security module David Howells
2016-04-07 16:23 ` [PATCH 9/9] rxrpc: Create a null security type and get rid of conditional calls David Howells
2016-04-11 19:35 ` [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Miller
2016-04-11 20:38 ` David Howells
2016-04-11 22:01 ` David Howells
2016-04-12 1:26 ` David Miller
2016-04-11 22:29 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407.133843.156901424652264502.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=joe@perches.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).