From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: alexei.starovoitov@gmail.com, tom@herbertland.com,
netdev@vger.kernel.org
Subject: Re: optimizations to sk_buff handling in rds_tcp_data_ready
Date: Thu, 7 Apr 2016 15:29:46 -0400 [thread overview]
Message-ID: <20160407192946.GA10957@oracle.com> (raw)
In-Reply-To: <1460038560.6473.397.camel@edumazet-glaptop3.roam.corp.google.com>
On (04/07/16 07:16), Eric Dumazet wrote:
> Use skb split like TCP in output path ?
That almost looks like what I want, but skb_split modifies both
skb and skb1, and I want to leave skb untouched (otherwise
I will mess up the book-keeping in tcp_read_sock). But skb_split
is a good template- I think it could even be extended to avoid copying
the frags that we'd later trim off in rds_tcp_data_recv anyway,
let me see what I can come up with, based on that code.
> Really, pskb_expand_head() is not supposed to copy payload ;)
That would make my world very easy! But it has callers from all
over the kernel, e.g., skb_realloc_headroom, and changing it is
obviously risky
next prev parent reply other threads:[~2016-04-07 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 13:11 optimizations to sk_buff handling in rds_tcp_data_ready Sowmini Varadhan
2016-04-07 14:16 ` Eric Dumazet
2016-04-07 19:29 ` Sowmini Varadhan [this message]
2016-04-10 0:18 ` Sowmini Varadhan
2016-04-10 23:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407192946.GA10957@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).