From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, fcooper@ti.com, samanthakumar@google.com,
willemb@google.com
Subject: Re: [PATCH net-next 0/2] fix udp pull header breakage
Date: Mon, 11 Apr 2016 15:31:56 -0400 (EDT) [thread overview]
Message-ID: <20160411.153156.115903140123859564.davem@davemloft.net> (raw)
In-Reply-To: <1460043899-56894-1-git-send-email-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Thu, 7 Apr 2016 11:44:57 -0400
> Commit e6afc8ace6dd ("udp: remove headers from UDP packets before
> queueing") modified udp receive processing to pull headers before
> enqueue and to not expect them on dequeue.
>
> The patch missed protocols on top of udp with in-kernel
> implementations that have their own skb_recv_datagram calls and
> dequeue logic. Modify these datapaths to also no longer expect
> a udp header at skb->data.
>
> Sunrpc and rxrpc are the only two protocols that call this
> function and contain references to udphr (some others, like tipc,
> are based on encap_rcv, which acts before enqueue, before the
> the header pull).
Series applied, thanks for fixing this regression so quickly.
prev parent reply other threads:[~2016-04-11 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:44 [PATCH net-next 0/2] fix udp pull header breakage Willem de Bruijn
2016-04-07 15:44 ` [PATCH net-next 1/2] sunrpc: do not pull udp headers on receive Willem de Bruijn
2016-04-08 7:47 ` [net-next,1/2] " Thierry Reding
2016-04-07 15:44 ` [PATCH net-next 2/2] rxrpc: " Willem de Bruijn
2016-04-08 7:48 ` [net-next,2/2] " Thierry Reding
2016-04-11 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411.153156.115903140123859564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fcooper@ti.com \
--cc=netdev@vger.kernel.org \
--cc=samanthakumar@google.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).