netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: blogic@openwrt.org
Cc: nbd@openwrt.org, matthias.bgg@gmail.com, netdev@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net-next: mediatek: add support for IRQ grouping
Date: Wed, 13 Apr 2016 22:22:38 -0400 (EDT)	[thread overview]
Message-ID: <20160413.222238.1174020501502372148.davem@davemloft.net> (raw)
In-Reply-To: <1460053499-53659-1-git-send-email-blogic@openwrt.org>

From: John Crispin <blogic@openwrt.org>
Date: Thu,  7 Apr 2016 20:24:59 +0200

> The ethernet core has 3 IRQs. Using the IRQ grouping registers we are able
> to separate TX and RX IRQs, which allows us to service them on separate
> cores. This patch splits the IRQ handler into 2 separate functions, one
> for TX and another for RX. The TX housekeeping is split out of the NAPI
> handler. Instead we use a tasklet to handle housekeeping.
> 
> Signed-off-by: John Crispin <blogic@openwrt.org>

Don't do this with tasklets.

Do your TX reclaim in a NAPI poll just like the RX side.

      reply	other threads:[~2016-04-14  2:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 18:24 [PATCH] net-next: mediatek: add support for IRQ grouping John Crispin
2016-04-14  2:22 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413.222238.1174020501502372148.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=blogic@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).