From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: Do not keep linklocal and loopback addresses
Date: Wed, 13 Apr 2016 23:00:02 -0400 (EDT) [thread overview]
Message-ID: <20160413.230002.1718430497071707670.davem@davemloft.net> (raw)
In-Reply-To: <1460142081-16675-1-git-send-email-dsa@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Fri, 8 Apr 2016 12:01:21 -0700
> f1705ec197e7 added the option to retain user configured addresses on an
> admin down. A comment to one of the later revisions suggested using the
> IFA_F_PERMANENT flag rather than adding a user_managed boolean to the
> ifaddr struct. A side effect of this change is that link local and
> loopback addresses are also retained which is not part of the objective
> of f1705ec197e7. Add check to drop those addresses.
>
> Fixes: f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional")
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied, but two things:
Please do not put an empty line between the Fixes: and other tags.
All tags are equal and should be placed together as an unsegmented
unit.
Second, please be really sure this is the final set of semantics
you want. If we flap again on this after 4.6-final goes out the
door, I will be very unpleased to say the least.
Thanks.
next prev parent reply other threads:[~2016-04-14 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 19:01 [PATCH] net: ipv6: Do not keep linklocal and loopback addresses David Ahern
2016-04-14 3:00 ` David Miller [this message]
2016-04-14 3:13 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413.230002.1718430497071707670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).