Re: [PATCH RFC 2/2] tun: don't set a default qdisc

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Apr 13, 2016 at 11:04:47AM +0200, Paolo Abeni wrote:
> This patch disables the default qdisc by explicitly setting the
> IFF_NO_QUEUE private flag so that now the tun xmit path do not
> require any lock by default.
> 
> The default qdisc was first removed as a side effect of commit
> f84bb1eac027 ("net: fix IFF_NO_QUEUE for drivers using alloc_netdev")
> and recently restored with commit 016adb7260f4 ("tuntap: restore default qdisc")
> 
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

I wonder about this back and forth.
Jason, do you see a workload where the default qdisc
is preferable?

> ---
>  drivers/net/tun.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 42992dc..0a0b63c 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -1081,6 +1081,7 @@ static void tun_net_init(struct net_device *dev)
>  
>  		break;
>  	}
> +	dev->priv_flags |= IFF_NO_QUEUE;
>  }
>  
>  /* Character device part */
> -- 
> 1.8.3.1