netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] gre: eliminate holes in ip_tunnel
@ 2016-04-14  0:02 Stephen Hemminger
  2016-04-14  5:16 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2016-04-14  0:02 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

The structure can be packed denser by doing minor rearrangement
of existing elements.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>


--- a/include/net/ip_tunnels.h	2016-04-11 13:42:06.654666930 -0700
+++ b/include/net/ip_tunnels.h	2016-04-13 16:47:59.821692189 -0700
@@ -105,24 +105,23 @@ struct ip_tunnel {
 	struct net_device	*dev;
 	struct net		*net;	/* netns for packet i/o */
 
-	int		err_count;	/* Number of arrived ICMP errors */
 	unsigned long	err_time;	/* Time when the last ICMP error
 					 * arrived */
+	int		err_count;	/* Number of arrived ICMP errors */
 
 	/* These four fields used only by GRE */
 	u32		i_seqno;	/* The last seen seqno	*/
 	u32		o_seqno;	/* The last output seqno */
 	int		tun_hlen;	/* Precalculated header length */
-	int		mlink;
 
 	struct dst_cache dst_cache;
 
 	struct ip_tunnel_parm parms;
 
+	int		mlink;
 	int		encap_hlen;	/* Encap header length (FOU,GUE) */
-	struct ip_tunnel_encap encap;
-
 	int		hlen;		/* tun_hlen + encap_hlen */
+	struct ip_tunnel_encap encap;
 
 	/* for SIT */
 #ifdef CONFIG_IPV6_SIT_6RD

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] gre: eliminate holes in ip_tunnel
  2016-04-14  0:02 [PATCH net-next] gre: eliminate holes in ip_tunnel Stephen Hemminger
@ 2016-04-14  5:16 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-04-14  5:16 UTC (permalink / raw)
  To: stephen; +Cc: netdev

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 13 Apr 2016 17:02:21 -0700

> The structure can be packed denser by doing minor rearrangement
> of existing elements.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-14  5:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-14  0:02 [PATCH net-next] gre: eliminate holes in ip_tunnel Stephen Hemminger
2016-04-14  5:16 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).