From: Phil Sutter <phil@nwl.cc>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Deleting child qdisc doesn't reset parent to default qdisc?
Date: Thu, 14 Apr 2016 18:22:29 +0200 [thread overview]
Message-ID: <20160414162229.GF3715@orbyte.nwl.cc> (raw)
In-Reply-To: <1460648680.10638.47.camel@edumazet-glaptop3.roam.corp.google.com>
On Thu, Apr 14, 2016 at 08:44:40AM -0700, Eric Dumazet wrote:
> On Thu, 2016-04-14 at 17:34 +0200, Jiri Kosina wrote:
> > On Thu, 14 Apr 2016, Phil Sutter wrote:
> >
> > > OTOH some qdiscs (CBQ, DRR, DSMARK, HFSC, HTB, QFQ) assign the default
> > > one upon deletion instead of noop_qdisc, hence I would describe
> > > the situation using the words 'inconsistent' and 'accident' rather than
> > > 'expected'. :)
> >
> > Exactly. I'd again like to stress the fact that this configuration works:
> >
> > jikos:~ # tc qdisc show
> > qdisc tbf 10: dev eth0 root refcnt 2 rate 800Mbit burst 131000b lat 1.0ms
> >
> > and this (after performing add/delete operation) doesn't:
> >
> > jikos:~ # tc qdisc show
> > qdisc tbf 10: dev eth0 root refcnt 2 rate 800Mbit burst 131000b lat 1.0ms
> >
> > It's hard to spot a difference (hint: there is none).
>
> This is because some qdisc are not visible in the dump.
And those being invisible can be overridden using 'tc qd add', right?
AFAIR they're not listed because they don't properly register, so the
system doesn't care to override them. In this case we could change all
classful qdiscs to restore the default qdisc if a leaf qdisc is being
deleted instead of noop (which is probably not what the user wants
anyway).
Cheers, Phil
next prev parent reply other threads:[~2016-04-14 16:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 14:44 Deleting child qdisc doesn't reset parent to default qdisc? Jiri Kosina
2016-04-14 14:51 ` Jiri Kosina
2016-04-14 15:01 ` Eric Dumazet
2016-04-14 15:18 ` Phil Sutter
2016-04-14 15:34 ` Jiri Kosina
2016-04-14 15:44 ` Eric Dumazet
2016-04-14 16:22 ` Phil Sutter [this message]
2016-04-14 16:40 ` Eric Dumazet
2016-04-14 16:08 ` Jiri Kosina
2016-04-14 17:49 ` Eric Dumazet
2016-04-15 12:42 ` Jamal Hadi Salim
2016-04-15 14:58 ` Eric Dumazet
2016-04-15 17:13 ` David Miller
2016-06-28 15:19 ` Jiri Kosina
2016-06-28 17:28 ` Cong Wang
2016-06-28 17:33 ` Jiri Kosina
2016-06-28 16:49 ` [RFC PATCH] sch_tbf: avoid silent fallback to noop_qdisc (was Re: Deleting child qdisc doesn't reset parent to default qdisc?) Jiri Kosina
2016-07-07 9:04 ` [RFC PATCH] net: sched: convert qdisc linked list to hashtable " Jiri Kosina
2016-07-07 13:51 ` Eric Dumazet
2016-07-07 16:32 ` Jiri Kosina
2016-07-07 16:53 ` Eric Dumazet
2016-07-07 20:36 ` [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable Jiri Kosina
2016-07-08 8:50 ` Eric Dumazet
2016-07-08 9:02 ` Jiri Kosina
2016-07-08 11:07 ` Thomas Graf
2016-07-08 13:52 ` Eric Dumazet
2016-07-11 14:02 ` [RFC PATCH v3] " Jiri Kosina
2016-07-12 17:36 ` Cong Wang
2016-07-13 13:47 ` Jiri Kosina
2016-07-28 9:56 ` [PATCH v4] " Jiri Kosina
2016-07-28 11:10 ` kbuild test robot
2016-07-28 11:18 ` Jiri Kosina
2016-07-28 12:53 ` Fengguang Wu
2016-07-28 16:53 ` Cong Wang
2016-07-31 11:21 ` Fengguang Wu
2016-08-01 10:12 ` Jiri Kosina
2016-07-28 11:22 ` kbuild test robot
2016-07-28 11:52 ` kbuild test robot
2016-07-28 16:52 ` Cong Wang
2016-07-29 7:49 ` [PATCH v5] " Jiri Kosina
2016-07-29 20:01 ` kbuild test robot
2016-07-31 0:11 ` kbuild test robot
2016-08-01 10:23 ` [PATCH v6] " Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414162229.GF3715@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).