From: Alexander Duyck <aduyck@mirantis.com>
To: jesse@kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
alexander.duyck@gmail.com, tom@herbertland.com
Subject: [net-next PATCH 2/5] ip6gretap: Fix MTU to allow for Ethernet header
Date: Thu, 14 Apr 2016 15:33:45 -0400 [thread overview]
Message-ID: <20160414193345.12934.21014.stgit@ahduyck-xeon-server> (raw)
In-Reply-To: <20160414192709.12934.82858.stgit@ahduyck-xeon-server>
When we were creating an ip6gretap interface the MTU was about 6 bytes
short of what was needed. It turns out we were not taking the Ethernet
header into account and as a result we were eating into the 8 bytes
reserved for the encap limit.
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
net/ipv6/ip6_gre.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 4e636e60a360..2be66e7b4a78 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -987,6 +987,8 @@ static void ip6gre_tnl_link_config(struct ip6_tnl *t, int set_mtu)
dev->mtu = rt->dst.dev->mtu - addend;
if (!(t->parms.flags & IP6_TNL_F_IGN_ENCAP_LIMIT))
dev->mtu -= 8;
+ if (dev->type == ARPHRD_ETHER)
+ dev->mtu -= ETH_HLEN;
if (dev->mtu < IPV6_MIN_MTU)
dev->mtu = IPV6_MIN_MTU;
next prev parent reply other threads:[~2016-04-14 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 19:33 [net-next PATCH 0/5] Add support for offloads with IPv6 GRE tunnels Alexander Duyck
2016-04-14 19:33 ` [net-next PATCH 1/5] ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb Alexander Duyck
2016-04-14 19:33 ` Alexander Duyck [this message]
2016-04-14 19:33 ` [net-next PATCH 3/5] ip6gre: Add support for basic offloads offloads excluding GSO Alexander Duyck
2016-04-14 19:33 ` [net-next PATCH 4/5] GRE: Add support for GRO/GSO of IPv6 GRE traffic Alexander Duyck
2016-04-14 19:34 ` [net-next PATCH 5/5] ip6gre: Add support for GSO Alexander Duyck
2016-04-16 23:12 ` [net-next PATCH 0/5] Add support for offloads with IPv6 GRE tunnels David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414193345.12934.21014.stgit@ahduyck-xeon-server \
--to=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).