From: David Miller <davem@davemloft.net>
To: santosh.shilimkar@oracle.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map update
Date: Sat, 16 Apr 2016 19:01:42 -0400 (EDT) [thread overview]
Message-ID: <20160416.190142.1728042848852620447.davem@davemloft.net> (raw)
In-Reply-To: <1460655807-26236-3-git-send-email-santosh.shilimkar@oracle.com>
From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Thu, 14 Apr 2016 10:43:27 -0700
> Two different threads with different rds sockets may be in
> rds_recv_rcvbuf_delta() via receive path. If their ports
> both map to the same word in the congestion map, then
> using non-atomic ops to update it could cause the map to
> be incorrect. Lets use atomics to avoid such an issue.
>
> Full credit to Wengang <wen.gang.wang@oracle.com> for
> finding the issue, analysing it and also pointing out
> to offending code with spin lock based fix.
>
> Reviewed-by: Leon Romanovsky <leon@leon.nu>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Applied.
next prev parent reply other threads:[~2016-04-16 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 17:43 [net][PATCH v2 0/2] RDS: couple of fixes for 4.6 Santosh Shilimkar
2016-04-14 17:43 ` [net][PATCH v2 1/2] RDS: fix endianness for dp_ack_seq Santosh Shilimkar
2016-04-16 23:01 ` David Miller
2016-04-14 17:43 ` [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map update Santosh Shilimkar
2016-04-16 23:01 ` David Miller [this message]
2016-04-16 22:53 ` [net][PATCH v2 0/2] RDS: couple of fixes for 4.6 David Miller
2016-04-16 23:57 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416.190142.1728042848852620447.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).