* [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up
@ 2016-04-15 17:14 Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 1/2] staging: rtl8188eu: Convert to using IFF_NO_QUEUE Phil Sutter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Phil Sutter @ 2016-04-15 17:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The following series converts two further drivers away from setting
'tx_queue_len = 0' to adding IFF_NO_QUEUE to priv_flags instead.
The first one, rtl8188eu in staging didn't exist back when all drivers
were converted. The second one, openvswitch seems to have slipped through
my grep'ing back then, no idea why.
Phil Sutter (2):
staging: rtl8188eu: Convert to using IFF_NO_QUEUE
openvswitch: Convert to using IFF_NO_QUEUE
drivers/staging/rtl8188eu/os_dep/mon.c | 2 +-
net/openvswitch/vport-internal_dev.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.8.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 1/2] staging: rtl8188eu: Convert to using IFF_NO_QUEUE
2016-04-15 17:14 [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up Phil Sutter
@ 2016-04-15 17:14 ` Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 2/2] openvswitch: " Phil Sutter
2016-04-17 2:02 ` [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Phil Sutter @ 2016-04-15 17:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Jakub Sitnicki
Cc: Jakub Sitnicki <jsitnicki@gmail.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
drivers/staging/rtl8188eu/os_dep/mon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c
index 63bb87593af0c..d976e5e18d50e 100644
--- a/drivers/staging/rtl8188eu/os_dep/mon.c
+++ b/drivers/staging/rtl8188eu/os_dep/mon.c
@@ -155,7 +155,7 @@ static void mon_setup(struct net_device *dev)
dev->netdev_ops = &mon_netdev_ops;
dev->destructor = free_netdev;
ether_setup(dev);
- dev->tx_queue_len = 0;
+ dev->priv_flags |= IFF_NO_QUEUE;
dev->type = ARPHRD_IEEE80211;
/*
* Use a locally administered address (IEEE 802)
--
2.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] openvswitch: Convert to using IFF_NO_QUEUE
2016-04-15 17:14 [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 1/2] staging: rtl8188eu: Convert to using IFF_NO_QUEUE Phil Sutter
@ 2016-04-15 17:14 ` Phil Sutter
2016-04-17 2:02 ` [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Phil Sutter @ 2016-04-15 17:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Pravin Shelar
Cc: Pravin Shelar <pshelar@nicira.com>
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
net/openvswitch/vport-internal_dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index 7c8b90bf0e540..2ee48e447b724 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -165,11 +165,10 @@ static void do_setup(struct net_device *netdev)
netdev->priv_flags &= ~IFF_TX_SKB_SHARING;
netdev->priv_flags |= IFF_LIVE_ADDR_CHANGE | IFF_OPENVSWITCH |
- IFF_PHONY_HEADROOM;
+ IFF_PHONY_HEADROOM | IFF_NO_QUEUE;
netdev->destructor = internal_dev_destructor;
netdev->ethtool_ops = &internal_dev_ethtool_ops;
netdev->rtnl_link_ops = &internal_dev_link_ops;
- netdev->tx_queue_len = 0;
netdev->features = NETIF_F_LLTX | NETIF_F_SG | NETIF_F_FRAGLIST |
NETIF_F_HIGHDMA | NETIF_F_HW_CSUM |
--
2.8.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up
2016-04-15 17:14 [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 1/2] staging: rtl8188eu: Convert to using IFF_NO_QUEUE Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 2/2] openvswitch: " Phil Sutter
@ 2016-04-17 2:02 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-04-17 2:02 UTC (permalink / raw)
To: phil; +Cc: netdev
From: Phil Sutter <phil@nwl.cc>
Date: Fri, 15 Apr 2016 19:14:18 +0200
> The following series converts two further drivers away from setting
> 'tx_queue_len = 0' to adding IFF_NO_QUEUE to priv_flags instead.
>
> The first one, rtl8188eu in staging didn't exist back when all drivers
> were converted. The second one, openvswitch seems to have slipped through
> my grep'ing back then, no idea why.
Series applied, thanks Phil.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-17 2:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 17:14 [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 1/2] staging: rtl8188eu: Convert to using IFF_NO_QUEUE Phil Sutter
2016-04-15 17:14 ` [PATCH net-next 2/2] openvswitch: " Phil Sutter
2016-04-17 2:02 ` [PATCH net-next 0/2] Minor IFF_NO_QUEUE conversion follow-up David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).