From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, jhs@mojatatu.com,
tgraf@suug.ch, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats
Date: Tue, 19 Apr 2016 18:49:20 -0400 (EDT) [thread overview]
Message-ID: <20160419.184920.1193931883675948435.davem@davemloft.net> (raw)
In-Reply-To: <5716815C.6080601@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Tue, 19 Apr 2016 12:05:00 -0700
> ok, will do. one thing though, for GETSTATS, if I need a pad
> attribute like IFLA_PAD, I will need to add a new stats attribute
> IFLA_STATS_PAD and burn a bit for it in filter_mask too. In which
> case, I am wondering if we should live with the copy. I will take
> any suggestions here.
I don't think the copy is appropriate, especially if the existing full
link state dump gets away without it. We're adding this facility for
performance reasons after all.
You have several options to avoid wasting filter mask space. For
example, you could use IFLA_STATS_UNSPEC, which should be OK since
only new applications will use these.
Or you could make IFLA_STATS_PAD the first attribute, and define the
filter mask as relative to it. Ie. IFLA_STATS_LINK_64 uses bit
(IFLA_STATS_LINK_64 - IFLA_STATS_PAD), etc.
next prev parent reply other threads:[~2016-04-19 22:49 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 21:10 [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-18 21:35 ` Eric Dumazet
2016-04-19 0:57 ` David Miller
2016-04-19 1:48 ` David Miller
2016-04-19 2:22 ` Eric Dumazet
2016-04-19 2:40 ` Roopa Prabhu
2016-04-19 3:49 ` David Miller
2016-04-19 3:52 ` David Miller
2016-04-19 10:09 ` Johannes Berg
2016-04-19 10:48 ` Emmanuel Grumbach
2016-04-19 18:23 ` David Miller
2016-04-19 19:41 ` Johannes Berg
2016-04-20 1:53 ` David Ahern
2016-04-20 7:32 ` Johannes Berg
2016-04-20 12:48 ` Jiri Benc
2016-04-20 13:17 ` Johannes Berg
2016-04-20 13:34 ` Jiri Benc
2016-04-20 20:13 ` Johannes Berg
2016-04-19 2:30 ` roopa
2016-04-19 3:41 ` David Miller
2016-04-19 4:17 ` Eric Dumazet
2016-04-19 4:32 ` Eric Dumazet
2016-04-19 5:03 ` David Miller
2016-04-19 18:31 ` David Miller
2016-04-19 18:45 ` Eric Dumazet
2016-04-19 18:47 ` Eric Dumazet
2016-04-19 19:08 ` Nicolas Dichtel
2016-04-19 23:50 ` David Miller
2016-04-20 3:54 ` Roopa Prabhu
2016-04-20 8:57 ` [PATCH net-next 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit() Nicolas Dichtel
2016-04-20 9:33 ` Eric Dumazet
2016-04-20 9:44 ` Nicolas Dichtel
2016-04-20 9:57 ` Eric Dumazet
2016-04-20 10:14 ` Nicolas Dichtel
2016-04-20 14:31 ` [PATCH net-next] net: fix HAVE_EFFICIENT_UNALIGNED_ACCESS typos Eric Dumazet
2016-04-20 15:03 ` David Miller
2016-04-20 8:57 ` [PATCH net-next 2/4] libnl: add more helpers to align attribute on 64-bit Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 3/4] ipmr: align RTA_MFC_STATS " Nicolas Dichtel
2016-04-20 8:57 ` [PATCH net-next 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 1/4] libnl: add more helpers to align attributes on 64-bit Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 2/4] rtnl: use the new API to align IFLA_STATS* Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 3/4] ipmr: align RTA_MFC_STATS on 64-bit Nicolas Dichtel
2016-04-21 16:58 ` [PATCH net-next v2 4/4] ip6mr: " Nicolas Dichtel
2016-04-21 18:28 ` [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute David Miller
2016-04-21 22:00 ` Nicolas Dichtel
2016-04-22 5:31 ` David Miller
2016-04-19 19:05 ` [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats Roopa Prabhu
2016-04-19 22:49 ` David Miller [this message]
2016-04-20 3:53 ` Roopa Prabhu
2016-04-19 4:43 ` Roopa Prabhu
2016-04-19 7:45 ` Nicolas Dichtel
2016-04-19 16:00 ` David Miller
2016-04-19 8:26 ` Nicolas Dichtel
2016-04-19 19:55 ` Paul Moore
2016-04-19 20:40 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419.184920.1193931883675948435.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=roopa@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).