netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew.goodbody@cambrionix.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs
Date: Tue, 19 Apr 2016 20:15:50 -0400 (EDT)	[thread overview]
Message-ID: <20160419.201550.902520333910307559.davem@davemloft.net> (raw)
In-Reply-To: <1460987606-18125-1-git-send-email-andrew.goodbody@cambrionix.com>

From: Andrew Goodbody <andrew.goodbody@cambrionix.com>
Date: Mon, 18 Apr 2016 14:53:25 +0100

> This is a fix for a NULL pointer dereference from cpsw which is triggered
> by having two slave PHYs attached to a cpsw network device. The problem is
> due to only maintaining a single reference to a PHY node in the prive data
> which gets overwritten by the second PHY probe. So move the PHY node
> reference to the individual slave data so that there is now one per slave.
> 
> v1 had a problem that data->slaves was used before it had been filled in

I already applied v1 the other day, so you need to send me a relative
patch rather than a whole new one.

Thanks.

  parent reply	other threads:[~2016-04-20  0:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 13:53 [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody
2016-04-18 13:53 ` [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs Andrew Goodbody
2016-04-20  0:15 ` David Miller [this message]
2016-04-20  8:49   ` [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody
2016-04-20 14:56     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2016-04-19 13:56 Andrew Goodbody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160419.201550.902520333910307559.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew.goodbody@cambrionix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).