From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/7] net: network drivers should not depend on geneve/vxlan Date: Tue, 19 Apr 2016 21:11:34 -0400 (EDT) Message-ID: <20160419.211134.2163748309501010595.davem@davemloft.net> References: <1461007188-1603-1-git-send-email-hannes@stressinduktion.org> <20160419.202750.1844614056540086769.davem@davemloft.net> <1461114373.2649930.583890089.0C126826@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jesse@kernel.org To: hannes@stressinduktion.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:39027 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753057AbcDTBLg (ORCPT ); Tue, 19 Apr 2016 21:11:36 -0400 In-Reply-To: <1461114373.2649930.583890089.0C126826@webmail.messagingengine.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Hannes Frederic Sowa Date: Wed, 20 Apr 2016 03:06:13 +0200 > On Wed, Apr 20, 2016, at 02:27, David Miller wrote: >> From: Hannes Frederic Sowa >> Date: Mon, 18 Apr 2016 21:19:41 +0200 >> >> > This patchset removes the dependency of network drivers on vxlan or >> > geneve, so those don't get autoloaded when the nic driver is loaded. >> > >> > Also audited the code such that vxlan_get_rx_port and geneve_get_rx_port >> > are not called without rtnl lock. >> >> In net-next, the 'qed' driver has tunneling offload support too. >> Don't you need to update this series to handle that driver as >> well? > > I audited qede as well: > > qede calls {vxlan,geneve}_get_rx_port only from ndo_open which isn't > reused anywhere else in the driver, only from ndo_open, which holds > rtnl_lock also. Thus the driver is safe and doesn't need a change. I'm talking about your final patches which elide the dependencies.