From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, arnd@arndb.de, sd@queasysnail.net,
hannes@stressinduktion.org, johannes@sipsolutions.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] macsec: fix crypto Kconfig dependency
Date: Tue, 19 Apr 2016 07:44:55 +1000 [thread overview]
Message-ID: <20160419074455.10a96986@canb.auug.org.au> (raw)
In-Reply-To: <20160418.124316.1862068166928198574.davem@davemloft.net>
Hi Dave,
On Mon, 18 Apr 2016 12:43:16 -0400 (EDT) David Miller <davem@davemloft.net> wrote:
>
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Mon, 18 Apr 2016 18:43:36 +0800
>
> > Right, the problem is that nothing within crypto ever selects
> > CRYPTO since it's also used as a way of hiding the crypto menu
> > options.
>
> As far as I understand it, this won't help. Because selects do not
> trigger other selects and dependencies.
My understanding is that selects trigger other selects, but do not
honour dependencies. So, in general, you should not select a symbol
that has dependencies (unless you also have the same dependencies or
select those dependencies).
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2016-04-18 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 9:19 [PATCH] macsec: fix crypto Kconfig dependency Arnd Bergmann
2016-04-17 22:52 ` David Miller
2016-04-18 8:02 ` Herbert Xu
2016-04-18 10:23 ` Arnd Bergmann
2016-04-18 10:43 ` Herbert Xu
2016-04-18 11:07 ` Arnd Bergmann
2016-04-18 16:43 ` David Miller
2016-04-18 21:44 ` Stephen Rothwell [this message]
2016-04-18 16:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419074455.10a96986@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).