From: Dan Carpenter <dan.carpenter@oracle.com>
To: "David S. Miller" <davem@davemloft.net>,
Alexander Duyck <aduyck@mirantis.com>
Cc: Jesse Gross <jesse@kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Pravin B Shelar <pshelar@nicira.com>,
Jiri Benc <jbenc@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Tom Herbert <tom@herbertland.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] geneve: testing the wrong variable in geneve6_build_skb()
Date: Tue, 19 Apr 2016 17:30:56 +0300 [thread overview]
Message-ID: <20160419143056.GD4876@mwanda> (raw)
We intended to test "err" and not "skb".
Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index efbc7ce..512dbe0 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -733,7 +733,7 @@ static int geneve6_build_skb(struct dst_entry *dst, struct sk_buff *skb,
goto free_dst;
err = udp_tunnel_handle_offloads(skb, udp_sum);
- if (IS_ERR(skb))
+ if (err)
goto free_dst;
gnvh = (struct genevehdr *)__skb_push(skb, sizeof(*gnvh) + opt_len);
next reply other threads:[~2016-04-19 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 14:30 Dan Carpenter [this message]
2016-04-19 17:57 ` [patch -next] geneve: testing the wrong variable in geneve6_build_skb() Alexander Duyck
2016-04-21 18:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419143056.GD4876@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aduyck@mirantis.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=jesse@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).