Netdev List
 help / color / mirror / Atom feed
From: Alexander Duyck <aduyck@mirantis.com>
To: eugenia@mellanox.com, bruce.w.allan@intel.com,
	saeedm@mellanox.com, netdev@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org, ariel.elior@qlogic.com,
	mchan@broadcom.com
Subject: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums
Date: Tue, 19 Apr 2016 15:06:09 -0400	[thread overview]
Message-ID: <20160419190609.11723.8710.stgit@ahduyck-xeon-server> (raw)
In-Reply-To: <20160419185949.11723.50506.stgit@ahduyck-xeon-server>

This patch assumes that the bnx2x hardware will ignore existing IPv4/v6
header fields for length and checksum as well as the length and checksum
fields for outer UDP and GRE headers.

I have no means of testing this as I do not have any bnx2x hardware but
thought I would submit it as an RFC to see if anyone out there wants to
test this and see if this does in fact enable this functionality allowing
us to to segment tunneled frames that have an outer checksum.

Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |   13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index d465bd721146..e3459524fb0e 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -13258,14 +13258,21 @@ static int bnx2x_init_dev(struct bnx2x *bp, struct pci_dev *pdev,
 		NETIF_F_RXCSUM | NETIF_F_LRO | NETIF_F_GRO |
 		NETIF_F_RXHASH | NETIF_F_HW_VLAN_CTAG_TX;
 	if (!chip_is_e1x) {
-		dev->hw_features |= NETIF_F_GSO_GRE | NETIF_F_GSO_UDP_TUNNEL |
-				    NETIF_F_GSO_IPIP | NETIF_F_GSO_SIT;
+		dev->hw_features |= NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM |
+				    NETIF_F_GSO_IPIP | NETIF_F_GSO_SIT |
+				    NETIF_F_GSO_UDP_TUNNEL |
+				    NETIF_F_GSO_UDP_TUNNEL_CSUM |
+				    NETIF_F_GSO_PARTIAL;
 		dev->hw_enc_features =
 			NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_SG |
 			NETIF_F_TSO | NETIF_F_TSO_ECN | NETIF_F_TSO6 |
 			NETIF_F_GSO_IPIP |
 			NETIF_F_GSO_SIT |
-			NETIF_F_GSO_GRE | NETIF_F_GSO_UDP_TUNNEL;
+			NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM |
+			NETIF_F_GSO_UDP_TUNNEL | NETIF_F_GSO_UDP_TUNNEL_CSUM |
+			NETIF_F_GSO_PARTIAL;
+		dev->gso_partial_features = NETIF_F_GSO_GRE_CSUM |
+					    NETIF_F_GSO_UDP_TUNNEL_CSUM;
 	}
 
 	dev->vlan_features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |

  parent reply	other threads:[~2016-04-19 19:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 19:05 [RFC PATCH 0/5] Add GSO Partial support for devices with existing tunnel offloads Alexander Duyck
2016-04-19 19:05 ` [RFC PATCH 1/5] mlx4: Add support for UDP tunnel segmentation with outer checksum offload Alexander Duyck
2016-04-19 19:06 ` [RFC PATCH 2/5] mlx5: " Alexander Duyck
2016-04-20 17:40   ` Saeed Mahameed
2016-04-20 18:06     ` Alexander Duyck
2016-04-28 21:43       ` Matthew Finlay
2016-04-28 22:04         ` Alexander Duyck
2016-04-29  1:18           ` Matthew Finlay
2016-04-29  1:59             ` Alexander Duyck
2016-04-29 19:27               ` Saeed Mahameed
2016-04-29 19:36                 ` Alexander Duyck
2016-04-19 19:06 ` Alexander Duyck [this message]
2016-08-24 12:33   ` [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums Yuval Mintz
2016-08-24 15:39     ` Alexander Duyck
2016-08-25  5:06       ` Yuval Mintz
2016-08-25 18:26         ` Alexander Duyck
2016-08-31 11:31           ` Yuval Mintz
2016-08-31 16:13             ` Alexander Duyck
2016-04-19 19:06 ` [RFC PATCH 4/5] bnxt: " Alexander Duyck
2016-04-27  5:55   ` Michael Chan
2016-04-27 15:21     ` Alexander Duyck
2016-04-28  4:32       ` Michael Chan
2016-04-29 21:17         ` Alexander Duyck
2016-04-29 21:29           ` Michael Chan
2016-04-29 21:31             ` Alexander Duyck
2016-04-29 23:29               ` Michael Chan
2016-04-29 23:39                 ` Alexander Duyck
2016-04-19 19:06 ` [RFC PATCH 5/5] fm10k: Add support for UDP tunnel segmentation with outer checksum offload Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160419190609.11723.8710.stgit@ahduyck-xeon-server \
    --to=aduyck@mirantis.com \
    --cc=ariel.elior@qlogic.com \
    --cc=bruce.w.allan@intel.com \
    --cc=eugenia@mellanox.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox