* [PATCH] net: nla_align_64bit() needs to test the right pointer.
@ 2016-04-20 19:43 David Miller
0 siblings, 0 replies; only message in thread
From: David Miller @ 2016-04-20 19:43 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
Netlink messages are appended, one object at a time, to the end of
the SKB. Therefore we need to test skb_tail_pointer(), not skb->data,
for alignment purposes.
Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink attributes.")
Signed-off-by: David S. Miller <davem@davemloft.net>
---
This is like a never ending story....
include/net/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/netlink.h b/include/net/netlink.h
index cf95df1..3c1fd92 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -1250,7 +1250,7 @@ static inline int nla_align_64bit(struct sk_buff *skb, int padattr)
* nlattr header for next attribute, will make nla_data()
* 8-byte aligned.
*/
- if (IS_ALIGNED((unsigned long)skb->data, 8) &&
+ if (IS_ALIGNED((unsigned long)skb_tail_pointer(skb), 8) &&
!nla_reserve(skb, padattr, 0))
return -EMSGSIZE;
#endif
--
2.4.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-20 19:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 19:43 [PATCH] net: nla_align_64bit() needs to test the right pointer David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).