From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com,
talal@mellanox.com, eranbe@mellanox.com
Subject: Re: [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero
Date: Thu, 21 Apr 2016 14:04:54 -0400 (EDT) [thread overview]
Message-ID: <20160421.140454.143155848960923980.davem@davemloft.net> (raw)
In-Reply-To: <1461069222-27076-10-git-send-email-saeedm@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Tue, 19 Apr 2016 15:33:42 +0300
> Upon ethtool request to set speed to 0 we handle it as a special request
> to reset link modes to Device's defaults.
>
> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4
> Ethernet functionality")
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Please don't try to sneak things like this into the patches you submit.
If you continue to add weird stuff like this, I will never _ever_ be
able to trust you guys and have a high degree of confidence in your
changes. If you continue like this, I will always have to audit your
patches very strictly which is very time consuming for me.
Do not extend ethtool's semantics in a way which suits you specifically.
If we want to have this semantic, you must first propose it as a
global semantic which then in turn can be adopted by all drivers
supporting ethtool.
Thank you.
next prev parent reply other threads:[~2016-04-21 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 12:33 [PATCH net 0/9] mlx5 driver updates and fixes Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 1/9] net/mlx5_core: Fix soft lockup in steering error flow Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 2/9] net/mlx5e: Fix MLX5E_100BASE_T define Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 3/9] net/mlx5_core: Add ConnectX-5 to list of supported devices Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 4/9] net/mlx5e: Device's mtu field is u16 and not int Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 5/9] net/mlx5e: Fix minimum MTU Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 6/9] net/mlx5e: Use vport MTU rather than physical port MTU Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 7/9] net/mlx5_core: Remove static from local variable Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 8/9] net/mlx5: Add pci shutdown callback Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero Saeed Mahameed
2016-04-21 18:04 ` David Miller [this message]
2016-04-21 18:07 ` David Miller
2016-04-21 19:01 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421.140454.143155848960923980.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).