From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com,
talal@mellanox.com, eranbe@mellanox.com
Subject: Re: [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero
Date: Thu, 21 Apr 2016 14:07:23 -0400 (EDT) [thread overview]
Message-ID: <20160421.140723.1560539945918260688.davem@davemloft.net> (raw)
In-Reply-To: <20160421.140454.143155848960923980.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 21 Apr 2016 14:04:54 -0400 (EDT)
> From: Saeed Mahameed <saeedm@mellanox.com>
> Date: Tue, 19 Apr 2016 15:33:42 +0300
>
>> Upon ethtool request to set speed to 0 we handle it as a special request
>> to reset link modes to Device's defaults.
>>
>> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4
>> Ethernet functionality")
>> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
>
> Please don't try to sneak things like this into the patches you submit.
Also, this patch series doesn't even compile:
[davem@dhcp-10-15-49-210 net]$ make -s -j16
Makefile:679: Cannot use CONFIG_KCOV: -fsanitize-coverage=trace-pc is not supported by compiler
DESCEND objtool
drivers/infiniband/hw/mlx5/main.c: In function ‘mlx5_query_hca_port’:
drivers/infiniband/hw/mlx5/main.c:721:32: error: passing argument 2 of ‘mlx5_query_port_max_mtu’ from incompatible pointer type [-Werror=incompatible-pointer-types]
mlx5_query_port_max_mtu(mdev, &max_mtu, port);
^
In file included from drivers/infiniband/hw/mlx5/main.c:45:0:
include/linux/mlx5/port.h:58:6: note: expected ‘u16 * {aka short unsigned int *}’ but argument is of type ‘int *’
void mlx5_query_port_max_mtu(struct mlx5_core_dev *dev, u16 *max_mtu, u8 port);
^
drivers/infiniband/hw/mlx5/main.c:725:33: error: passing argument 2 of ‘mlx5_query_port_oper_mtu’ from incompatible pointer type [-Werror=incompatible-pointer-types]
mlx5_query_port_oper_mtu(mdev, &oper_mtu, port);
^
In file included from drivers/infiniband/hw/mlx5/main.c:45:0:
include/linux/mlx5/port.h:59:6: note: expected ‘u16 * {aka short unsigned int *}’ but argument is of type ‘int *’
void mlx5_query_port_oper_mtu(struct mlx5_core_dev *dev, u16 *oper_mtu,
^
cc1: some warnings being treated as errors
scripts/Makefile.build:291: recipe for target 'drivers/infiniband/hw/mlx5/main.o' failed
make[4]: *** [drivers/infiniband/hw/mlx5/main.o] Error 1
next prev parent reply other threads:[~2016-04-21 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 12:33 [PATCH net 0/9] mlx5 driver updates and fixes Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 1/9] net/mlx5_core: Fix soft lockup in steering error flow Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 2/9] net/mlx5e: Fix MLX5E_100BASE_T define Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 3/9] net/mlx5_core: Add ConnectX-5 to list of supported devices Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 4/9] net/mlx5e: Device's mtu field is u16 and not int Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 5/9] net/mlx5e: Fix minimum MTU Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 6/9] net/mlx5e: Use vport MTU rather than physical port MTU Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 7/9] net/mlx5_core: Remove static from local variable Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 8/9] net/mlx5: Add pci shutdown callback Saeed Mahameed
2016-04-19 12:33 ` [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero Saeed Mahameed
2016-04-21 18:04 ` David Miller
2016-04-21 18:07 ` David Miller [this message]
2016-04-21 19:01 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421.140723.1560539945918260688.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).