From: Rob Herring <robh@kernel.org>
To: Yisen Zhuang <Yisen.Zhuang@huawei.com>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
davem@davemloft.net, yankejian@huawei.com,
huangdaode@hisilicon.com, salil.mehta@huawei.com,
lipeng321@huawei.com, liguozhu@huawei.com,
xieqianqian@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH net-next 04/10] net: hns: add attribute reset-field-offset for dsaf node
Date: Fri, 22 Apr 2016 15:44:18 -0500 [thread overview]
Message-ID: <20160422204418.GA19071@rob-hp-laptop> (raw)
In-Reply-To: <1461309619-167621-5-git-send-email-Yisen.Zhuang@huawei.com>
On Fri, Apr 22, 2016 at 03:20:13PM +0800, Yisen Zhuang wrote:
> Add the subctrl reset offset for dsaf, this property is used to reset
> xge/ge ports for different dsaf. If this attribute is not present,
> default value 0 will be used.
>
> Signed-off-by: Daode Huang <huangdaode@hisilicon.com>
> Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
> ---
> .../devicetree/bindings/net/hisilicon-hns-dsaf.txt | 2 ++
Please put DT bindings in separate patches and don't modify the same
binding in a series of patches. You are describing h/w and the h/w is
not changing.
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 8 +++++
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h | 1 +
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 40 +++++++++++++++-------
> 4 files changed, 39 insertions(+), 12 deletions(-)
next prev parent reply other threads:[~2016-04-22 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 7:20 [PATCH net-next 00/10] net: hns: add support of debug dsaf device Yisen Zhuang
[not found] ` <1461309619-167621-1-git-send-email-Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-04-22 7:20 ` [PATCH net-next 01/10] net: hns: add a new dsaf mode for debug port Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 03/10] net: hns: add attribute port-idx-in-ae in enet node Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 04/10] net: hns: add attribute reset-field-offset for dsaf node Yisen Zhuang
2016-04-22 20:44 ` Rob Herring [this message]
2016-04-23 1:41 ` Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 06/10] net: hns: sort the header file by alphabetical order Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 09/10] net: hns: add attribute port-rst-offset for dsaf port node Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 02/10] net: hns: set debug port irq index to 0 Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 05/10] net: hns: add syscon operation for dsaf Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 07/10] net: hns: separate debug and service device from dsaf device Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 08/10] net: hns: add attribute cpld_ctrl for dsaf port node Yisen Zhuang
2016-04-22 7:20 ` [PATCH net-next 10/10] net: hns: add attribute port-mode-offset " Yisen Zhuang
-- strict thread matches above, loose matches on Subject: below --
2016-04-28 7:01 [PATCH net-next 00/10] net: hns: add support of debug dsaf device Yisen Zhuang
2016-04-28 7:01 ` [PATCH net-next 04/10] net: hns: add attribute reset-field-offset for dsaf node Yisen Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422204418.GA19071@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Yisen.Zhuang@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=huangdaode@hisilicon.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=liguozhu@huawei.com \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=salil.mehta@huawei.com \
--cc=xieqianqian@huawei.com \
--cc=yankejian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox