Re: [PATCH net 1/3] gre: do not assign header_ops in collect metadata mode

Thomas Graf
2016-04-23T01:41:47Z

On 04/22/16 at 11:20pm, Jiri Benc wrote:
> On Fri, 22 Apr 2016 14:04:48 -0700, pravin shelar wrote:
> > I think we should we return error in case of such configuration rather
> > than silently ignoring it.
>
> I thought about it and I'm not sure. We're not returning an error
> currently, starting returning it now might be perceived as uAPI
> breakage.
>
> But given it doesn't work at all currently, there are apparently no
> users yet. I'll wait for more feedback.

As a user, I would probably favour receiving an error for a configuration
that can't possibly work and was not working before.