From: Jiri Benc <jbenc@redhat.com>
To: pravin shelar <pshelar@ovn.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Pravin B Shelar <pshelar@nicira.com>, Thomas Graf <tgraf@suug.ch>,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [PATCH net 3/3] gre: receive also TEB packets for lwtunnels
Date: Sun, 24 Apr 2016 11:54:33 +0200 [thread overview]
Message-ID: <20160424115433.5c0a63ab@griffin> (raw)
In-Reply-To: <CAOrHB_DXzE8XNBmMc_VLzz+hkJCUmMVT2uMhWORCgq+g7ym9HA@mail.gmail.com>
On Fri, 22 Apr 2016 20:40:13 -0700, pravin shelar wrote:
> But skb->protocol is not set to ETH_P_TEB anywhere in ip-gre module.
> Am I missing something?
Ah, I see your point. It needs to be solved a bit differently, though,
we need to call __iptunnel_pull_header instead of iptunnel_pull_header
for these packets. I'll rework the patch.
> ip_tunnel_rcv() checks device type (tunnel->dev->type) to perform
> ethernet specific processing on packet. I think that should be changed
> to check packet type.
The current behavior is correct. The Ethernet processing depends on
the interface type, ARPHRD_IPGRE interfaces can't treat Ethernet
headers as L2 headers, that wouldn't match the interface type.
Jiri
next prev parent reply other threads:[~2016-04-24 9:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 17:44 [PATCH net 0/3] ipgre: fix lwtunnel support Jiri Benc
2016-04-22 17:44 ` [PATCH net 1/3] gre: do not assign header_ops in collect metadata mode Jiri Benc
2016-04-22 21:04 ` pravin shelar
2016-04-22 21:20 ` Jiri Benc
2016-04-23 1:41 ` Thomas Graf
2016-04-24 9:31 ` Jiri Benc
2016-04-22 17:44 ` [PATCH net 2/3] gre: build header correctly for collect metadata tunnels Jiri Benc
2016-04-22 21:05 ` pravin shelar
2016-04-23 0:03 ` Simon Horman
2016-04-22 17:44 ` [PATCH net 3/3] gre: receive also TEB packets for lwtunnels Jiri Benc
2016-04-22 21:07 ` pravin shelar
2016-04-22 21:27 ` Jiri Benc
2016-04-23 3:40 ` pravin shelar
2016-04-24 9:54 ` Jiri Benc [this message]
2016-04-23 1:49 ` Thomas Graf
2016-04-23 5:09 ` Simon Horman
2016-04-24 9:38 ` Jiri Benc
2016-04-28 6:49 ` Simon Horman
2016-04-28 8:23 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160424115433.5c0a63ab@griffin \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=pshelar@ovn.org \
--cc=simon.horman@netronome.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox