From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: Valdis.Kletnieks@vt.edu, hannes@stressinduktion.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] sock: relax WARN_ON() in sock_owned_by_user()
Date: Mon, 25 Apr 2016 11:50:06 -0400 (EDT) [thread overview]
Message-ID: <20160425.115006.523247588174639447.davem@davemloft.net> (raw)
In-Reply-To: <1461591249.5535.19.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 25 Apr 2016 06:34:09 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Valdis reported tons of stack dumps caused by WARN_ON() in
> sock_owned_by_user()
>
> This test needs to be relaxed if/when lockdep disables itself.
>
> Note that other lockdep_sock_is_held() callers are all from
> rcu_dereference_protected() sections which already are disabled
> if/when lockdep has been disabled.
>
> Fixes: fafc4e1ea1a4 ("sock: tigthen lockdep checks for sock_owned_by_user")
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks Eric.
next prev parent reply other threads:[~2016-04-25 15:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 0:30 linux-next: zillions of lockdep whinges in include/net/sock.h:1408 Valdis Kletnieks
2016-04-21 7:42 ` Hannes Frederic Sowa
2016-04-21 9:05 ` Valdis.Kletnieks
2016-04-21 13:31 ` Eric Dumazet
2016-04-21 13:49 ` Hannes Frederic Sowa
2016-04-24 18:38 ` David Miller
2016-04-24 18:48 ` Hannes Frederic Sowa
2016-04-24 18:54 ` David Miller
2016-04-24 19:55 ` Eric Dumazet
2016-04-24 19:46 ` Eric Dumazet
2016-04-24 19:56 ` Valdis.Kletnieks
2016-04-24 21:00 ` Eric Dumazet
2016-04-24 21:13 ` Valdis.Kletnieks
2016-04-24 21:25 ` Eric Dumazet
2016-04-24 21:28 ` Eric Dumazet
2016-04-25 13:26 ` Hannes Frederic Sowa
2016-04-25 13:34 ` [PATCH v2 net-next] sock: relax WARN_ON() in sock_owned_by_user() Eric Dumazet
2016-04-25 15:50 ` David Miller [this message]
2016-04-21 18:10 ` linux-next: zillions of lockdep whinges in include/net/sock.h:1408 Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425.115006.523247588174639447.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).