From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] route: move lwtunnel state to a single place Date: Mon, 25 Apr 2016 16:20:22 -0400 (EDT) Message-ID: <20160425.162022.201046855400100518.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, lrichard@redhat.com To: jbenc@redhat.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:33040 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964774AbcDYUUZ (ORCPT ); Mon, 25 Apr 2016 16:20:25 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Benc Date: Fri, 22 Apr 2016 12:40:02 +0200 > Commit 751a587ac9f9 ("route: fix breakage after moving lwtunnel state") > moved lwtstate to the end of dst_entry for 32bit archs. This makes it share > the cacheline with __refcnt which had an unkown effect on performance. For > this reason, the pointer was kept in place for 64bit archs. > > However, later performance measurements showed this is of no concern. It > turns out that every performance sensitive path that accesses lwtstate > accesses also struct rtable or struct rt6_info which share the same cache > line. > > Thus, to get rid of a few #ifdefs, move the field to the end of the struct > also for 64bit. > > Signed-off-by: Jiri Benc Fair enough, applied, thanks Jiri.