From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] sh_eth: use EDMR_SRST_GETHER in sh_eth_check_reset()
Date: Mon, 25 Apr 2016 10:31:15 +1000 [thread overview]
Message-ID: <20160425003115.GD30009@verge.net.au> (raw)
In-Reply-To: <10299839.69pLJTKjhc@wasted.cogentembedded.com>
On Sun, Apr 24, 2016 at 11:45:23PM +0300, Sergei Shtylyov wrote:
> sh_eth_check_reset() uses a bare number where EDMR_SRST_GETHER would fit,
> i.e. the receive/trasmit software reset bits that comprise EDMR_SRST_GETHER
> read as 1 while the corresponding reset is in progress and thus, when both
> are 0, the reset is complete.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2016-04-25 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 20:42 [PATCH 0/2] sh_eth: couple of software reset bit cleanups Sergei Shtylyov
2016-04-24 20:45 ` [PATCH 1/2] sh_eth: use EDMR_SRST_GETHER in sh_eth_check_reset() Sergei Shtylyov
2016-04-25 0:31 ` Simon Horman [this message]
2016-04-24 20:46 ` [PATCH 2/2] sh_eth: rename ARSTR register bit Sergei Shtylyov
2016-04-25 0:37 ` Simon Horman
2016-04-26 20:07 ` [PATCH 0/2] sh_eth: couple of software reset bit cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425003115.GD30009@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).