* [PATCH net-next] tc_act: export all user headers
@ 2016-04-22 17:06 Stephen Hemminger
2016-04-25 20:49 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2016-04-22 17:06 UTC (permalink / raw)
To: Jamal Hadi Salim, David Miller; +Cc: netdev
The file tc_ife.h was missing from the export list.
Rather than continue to cherry-pick, just export all headers in the directory.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/include/uapi/linux/tc_act/Kbuild 2015-05-21 15:13:05.121132983 -0700
+++ b/include/uapi/linux/tc_act/Kbuild 2016-04-22 10:03:24.733449078 -0700
@@ -1,12 +1,2 @@
# UAPI Header export list
-header-y += tc_csum.h
-header-y += tc_defact.h
-header-y += tc_gact.h
-header-y += tc_ipt.h
-header-y += tc_mirred.h
-header-y += tc_nat.h
-header-y += tc_pedit.h
-header-y += tc_skbedit.h
-header-y += tc_vlan.h
-header-y += tc_bpf.h
-header-y += tc_connmark.h
+header-y += *.h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] tc_act: export all user headers
2016-04-22 17:06 [PATCH net-next] tc_act: export all user headers Stephen Hemminger
@ 2016-04-25 20:49 ` David Miller
2016-04-25 20:52 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2016-04-25 20:49 UTC (permalink / raw)
To: stephen; +Cc: hadi, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 22 Apr 2016 10:06:38 -0700
> The file tc_ife.h was missing from the export list.
> Rather than continue to cherry-pick, just export all headers in the directory.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] tc_act: export all user headers
2016-04-25 20:49 ` David Miller
@ 2016-04-25 20:52 ` David Miller
2016-04-25 23:05 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2016-04-25 20:52 UTC (permalink / raw)
To: stephen; +Cc: hadi, netdev
From: David Miller <davem@davemloft.net>
Date: Mon, 25 Apr 2016 16:49:39 -0400 (EDT)
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Fri, 22 Apr 2016 10:06:38 -0700
>
>> The file tc_ife.h was missing from the export list.
>> Rather than continue to cherry-pick, just export all headers in the directory.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Applied.
Please compile test, pretty please??!?!?
./usr/include/linux/tc_act/*.h: No such file or directory
It looks like you can't expect shell expansions like that to work in
Kbuild files.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] tc_act: export all user headers
2016-04-25 20:52 ` David Miller
@ 2016-04-25 23:05 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2016-04-25 23:05 UTC (permalink / raw)
To: David Miller; +Cc: hadi, netdev
On Mon, 25 Apr 2016 16:52:44 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 25 Apr 2016 16:49:39 -0400 (EDT)
>
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Date: Fri, 22 Apr 2016 10:06:38 -0700
> >
> >> The file tc_ife.h was missing from the export list.
> >> Rather than continue to cherry-pick, just export all headers in the directory.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Applied.
>
> Please compile test, pretty please??!?!?
>
> ./usr/include/linux/tc_act/*.h: No such file or directory
>
> It looks like you can't expect shell expansions like that to work in
> Kbuild files.
It worked for me but was testing the export function, not the build.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-25 23:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-22 17:06 [PATCH net-next] tc_act: export all user headers Stephen Hemminger
2016-04-25 20:49 ` David Miller
2016-04-25 20:52 ` David Miller
2016-04-25 23:05 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).