From: David Miller <davem@davemloft.net>
To: fruggeri@arista.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com, maheshb@google.com
Subject: Re: [PATCH net-next] macvlan: fix failure during registration v3
Date: Tue, 26 Apr 2016 15:19:05 -0400 (EDT) [thread overview]
Message-ID: <20160426.151905.237092605462953849.davem@davemloft.net> (raw)
In-Reply-To: <1461449012-7401-1-git-send-email-fruggeri@arista.com>
From: Francesco Ruggeri <fruggeri@arista.com>
Date: Sat, 23 Apr 2016 15:03:32 -0700
> If macvlan_common_newlink fails in register_netdevice after macvlan_init
> then it decrements port->count twice, first in macvlan_uninit (from
> register_netdevice or rollback_registered) and then again in
> macvlan_common_newlink.
> A similar problem may exist in the ipvlan driver.
> This patch consolidates modifications to port->count into macvlan_init
> and macvlan_uninit (thanks to Eric Biederman for suggesting this approach).
>
> v3: remove macvtap specific bits.
>
> Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
Applied.
prev parent reply other threads:[~2016-04-26 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 22:03 [PATCH net-next] macvlan: fix failure during registration v3 Francesco Ruggeri
2016-04-25 19:00 ` Eric W. Biederman
2016-04-26 18:54 ` Mahesh Bandewar
2016-04-26 19:07 ` Francesco Ruggeri
2016-04-26 21:36 ` Mahesh Bandewar
2016-04-26 19:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426.151905.237092605462953849.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=fruggeri@arista.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox