From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: kiran.patil@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com
Subject: Re: [net-next 08/15] i40e: Allow user to change input set mask for flow director
Date: Tue, 26 Apr 2016 23:48:14 -0400 (EDT) [thread overview]
Message-ID: <20160426.234814.31916479145118247.davem@davemloft.net> (raw)
In-Reply-To: <1461704148-114349-9-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 26 Apr 2016 13:55:41 -0700
> From: Kiran Patil <kiran.patil@intel.com>
>
> This patch implements feature, which allows user to change
> input set mask for flow director using side-band channel.
> This patch adds definition of FLOW_TYPE_MASK into the header file.
> With this patch, user can now specify less than 4 tuple(src ip, dsp ip,
> src port, dst port) for flow type TCP4/UDP4.
>
> Change-Id: I90052508f8c172c0da5a4b78b949704b4a59ea78
> Signed-off-by: Kiran Patil <kiran.patil@intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
If you want to do this, you have to define the semantics generically
in include/uapi/linux/ethtool.h so that other drivers can implement
this too.
Please don't ever implement private, driver specific, interpretations
of the generic ethtool facilitites.
The semantics and interpretations of the values must absolutely be
consistent across all drivers in the tree.
Otherwise the user experience is terrible.
Thanks.
next prev parent reply other threads:[~2016-04-27 3:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 20:55 [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-04-26 Jeff Kirsher
2016-04-26 20:55 ` [net-next 01/15] i40e/i40evf: Clean up feature flags Jeff Kirsher
2016-04-26 20:55 ` [net-next 02/15] i40e/i40evf: Add support for IPIP and SIT offloads Jeff Kirsher
2016-04-26 20:55 ` [net-next 03/15] i40e: Add support for configuring VF RSS Jeff Kirsher
2016-04-26 20:55 ` [net-next 04/15] i40evf: Don't Panic Jeff Kirsher
2016-04-26 20:55 ` [net-next 05/15] i40e: Code cleanup in i40e_add_fdir_ethtool Jeff Kirsher
2016-04-26 20:55 ` [net-next 06/15] i40e: Specify AQ event opcode to wait for Jeff Kirsher
2016-04-26 20:55 ` [net-next 07/15] i40evf: Allow PF driver to configure RSS Jeff Kirsher
2016-04-26 20:55 ` [net-next 08/15] i40e: Allow user to change input set mask for flow director Jeff Kirsher
2016-04-27 3:48 ` David Miller [this message]
2016-05-05 2:47 ` Patil, Kiran
2016-05-05 3:22 ` John Fastabend
2016-05-05 15:00 ` Patil, Kiran
2016-05-05 3:57 ` David Miller
2016-05-05 3:52 ` Alexander Duyck
2016-04-26 20:55 ` [net-next 09/15] i40e: Add device capability which defines if update is available Jeff Kirsher
2016-04-26 20:55 ` [net-next 10/15] i40e: Add DeviceID for X722 QSFP+ Jeff Kirsher
2016-04-26 20:55 ` [net-next 11/15] i40e: Remove zero check Jeff Kirsher
2016-04-26 20:55 ` [net-next 12/15] i40e/i40evf: Only offload VLAN tag if enabled Jeff Kirsher
2016-04-26 20:55 ` [net-next 13/15] i40e: Add promiscuous on VLAN support Jeff Kirsher
2016-04-26 20:55 ` [net-next 14/15] i40e: Add VF promiscuous mode driver support Jeff Kirsher
2016-04-26 20:55 ` [net-next 15/15] i40evf: Add driver support for promiscuous mode Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426.234814.31916479145118247.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=kiran.patil@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).