From: David Miller <davem@davemloft.net>
To: mahesh@bandewar.net
Cc: maheshb@google.com, edumazet@google.com, netdev@vger.kernel.org,
ebiederm@xmission.com
Subject: Re: [PATCH next] ipvlan: Fix failure path in dev registration during link creation
Date: Wed, 27 Apr 2016 14:57:42 -0400 (EDT) [thread overview]
Message-ID: <20160427.145742.1732984000881376610.davem@davemloft.net> (raw)
In-Reply-To: <1461782259-10806-1-git-send-email-mahesh@bandewar.net>
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Wed, 27 Apr 2016 11:37:39 -0700
> While fixing this issue I noticed another issue of missing unregister
> in case of failure, so adding it to the fix which is similar to the
> macvlan fix by Francesco in SHA1:308379607548524b8d86dbf20134681024935e0b
This is not the correct way to refer to commits.
You should specify, exactly, 12 digits of the SHA1 value, followed by
a space, followed by the header line text of that commit contained in
parenthesis and double quotes, like how Fixes: tags specify commits.
next prev parent reply other threads:[~2016-04-27 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 18:37 [PATCH next] ipvlan: Fix failure path in dev registration during link creation Mahesh Bandewar
2016-04-27 18:57 ` David Miller [this message]
2016-04-27 20:39 ` Mahesh Bandewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427.145742.1732984000881376610.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).