From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH net] net/mlx4: Avoid wrong virtual mappings Date: Wed, 27 Apr 2016 00:19:20 -0700 Message-ID: <20160427071920.GA26712@infradead.org> References: <1461591287-11595-1-git-send-email-hagaya@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sinan Kaya , Timur Tabi , Eli Cohen , Or Gerlitz , Eran Ben Elisha , Yishai Hadas , Tal Alon , Saeed Mahameed To: Haggai Abramovsky Return-path: Content-Disposition: inline In-Reply-To: <1461591287-11595-1-git-send-email-hagaya-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Haggai, I've taken a very quick look because I'm a little too busy this week, but I failed to grasp the patch, as it seems to do a few too many things. E.g. the whole wqe_shrink thing doesn't correspond to anything in the description. How about you split it into easily understanable chunks? Also now that you split the few places that actually split the allocation into chunks to be handled special I think the whole mlx4_buf abstraction should go away, as it just obsfucates how different the different use cases are. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html