From: Francois Romieu <romieu@fr.zoreil.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 1/1] pch_gbe: replace private tx ring lock with common netif_tx_lock
Date: Wed, 27 Apr 2016 23:28:48 +0200 [thread overview]
Message-ID: <20160427212848.GA10269@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <57207E8A.8030004@cumulusnetworks.com>
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> :
> On 04/27/2016 12:49 AM, Francois Romieu wrote:
[...]
> > @@ -1652,7 +1652,7 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter,
> >
> > netdev_dbg(adapter->netdev, "next_to_clean : %d\n",
> > tx_ring->next_to_clean);
> > - spin_unlock(&tx_ring->tx_lock);
> > + netif_tx_lock(adapter->netdev);
>
> Shouldn't this be netif_tx_unlock ?
It should. Thanks for reviewing.
--
Ueimor
prev parent reply other threads:[~2016-04-27 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 22:49 [PATCH net-next 1/1] pch_gbe: replace private tx ring lock with common netif_tx_lock Francois Romieu
2016-04-27 8:55 ` Nikolay Aleksandrov
2016-04-27 21:28 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427212848.GA10269@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox