From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: iproute2: bash completion function for tc Date: Wed, 27 Apr 2016 22:13:46 -0700 Message-ID: <20160427221346.32ec7bcb@samsung9> References: <571F1891.1030004@6wind.com> <20160428031923.GA76700@ast-mbp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Quentin Monnet , Jamal Hadi Salim , Vincent Jardin , netdev@vger.kernel.org To: Alexei Starovoitov Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:36129 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbcD1FNu (ORCPT ); Thu, 28 Apr 2016 01:13:50 -0400 Received: by mail-pa0-f46.google.com with SMTP id bt5so27742947pac.3 for ; Wed, 27 Apr 2016 22:13:50 -0700 (PDT) In-Reply-To: <20160428031923.GA76700@ast-mbp.thefacebook.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 27 Apr 2016 20:19:26 -0700 Alexei Starovoitov wrote: > On Tue, Apr 26, 2016 at 09:28:17AM +0200, Quentin Monnet wrote: > > Hi Jamal, Stephen, > > > > I searched for a function providing auto-completion for `tc` utility in > > bash, but I found none. So I have created one, and I would like share it > > with the community. It is available here: > > https://github.com/6WIND/tc_bash-completion/blob/master/tc > > I would like to make it easily available to tc users, so here is a > > twofold request: > > > > * I do not know where to submit the code. Should I submit here on netdev > > for inclusion in iproute2 package, or rather to the bash-completion > > repository on GitHub? I feel like it would receive better feedback and > > updates if pushed to iproute2. Could you please provide some advice here? > > * The completion for `tc` seems to work well; I have tested it with many > > commands, but I am no tc expert, and there are probably some cases where > > the completion fails to propose the correct choices. I would be really > > interested in any feedback/bug reports that you, or anyone on this list > > who uses tc, could provide. > > that looks very interesting. > I think making it a part of iproute2 is a good thing. > How about installing it into /etc/iproute2/ ? > Stephen, any comments? > I am ok with keeping it in the repository. But it would need to be installed in the standard bash directory, is that distro dependent?