Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
	dvhart@infradead.org, andy.cress@us.kontron.com,
	bryan@fossetcon.org
Subject: Re: [PATCH net-next #2 1/1] pch_gbe: replace private tx ring lock with common netif_tx_lock
Date: Thu, 28 Apr 2016 17:21:56 -0400 (EDT)	[thread overview]
Message-ID: <20160428.172156.82071103410592107.davem@davemloft.net> (raw)
In-Reply-To: <20160427212944.GB10269@electric-eye.fr.zoreil.com>

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Wed, 27 Apr 2016 23:29:44 +0200

> pch_gbe_tx_ring.tx_lock is only used in the hard_xmit handler and
> in the transmit completion reaper called from NAPI context.
> 
> Compile-tested only. Potential victims Cced.
> 
> Someone more knowledgeable may check if pch_gbe_tx_queue could
> have some use for a mmiowb.
> 
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andy Cress <andy.cress@us.kontron.com>
> Cc: bryan@fossetcon.org
> 
> ---
>  Includes Nikolay's fix.

Applied, thank you.

      reply	other threads:[~2016-04-28 21:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 21:29 [PATCH net-next #2 1/1] pch_gbe: replace private tx ring lock with common netif_tx_lock Francois Romieu
2016-04-28 21:21 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428.172156.82071103410592107.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andy.cress@us.kontron.com \
    --cc=bryan@fossetcon.org \
    --cc=dvhart@infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox