From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, linux-kbuild@vger.kernel.org,
bblanco@plumgrid.com, borkmann@iogearbox.net,
alexei.starovoitov@gmail.com, brouer@redhat.com
Subject: Re: [net-next PATCH V4 1/5] samples/bpf: add back functionality to redefine LLC command
Date: Thu, 28 Apr 2016 16:40:46 +0200 [thread overview]
Message-ID: <20160428164046.0998f03d@redhat.com> (raw)
In-Reply-To: <20160428132132.GB7880@naverao1-tp.in.ibm.com>
On Thu, 28 Apr 2016 18:51:33 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> > Add this features back. Note that it is possible to redefine the LLC
> > on the make command like:
> >
> > make samples/bpf/ LLC=~/git/llvm/build/bin/llc
>
> I don't have an objection to this patch, but you didn't explain why/how
> this approach is better than just doing:
> PATH=~/git/llvm/build/bin make samples/bpf/
It is almost the same. There is always another way to do the same.
I explicitly use this to test different combinations of LLC and CLANG,
in-order to validate Alexei's claim that older versions of CLANG could
still work with a newer version of LLC. Thus, one use-case you
approach cannot cover ;-)
And clang seems to install a clang-3.9, which my solution also covers
by explicitly specifying CLANG=clang-3.9, if several avail clang's are
in the PATH.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2016-04-28 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 12:20 [net-next PATCH V4 0/5] samples/bpf: Improve user experience Jesper Dangaard Brouer
2016-04-28 12:20 ` [net-next PATCH V4 1/5] samples/bpf: add back functionality to redefine LLC command Jesper Dangaard Brouer
2016-04-28 13:21 ` Naveen N. Rao
2016-04-28 14:40 ` Jesper Dangaard Brouer [this message]
2016-04-28 14:50 ` Naveen N. Rao
2016-04-28 12:20 ` [net-next PATCH V4 2/5] samples/bpf: Makefile verify LLVM compiler avail and bpf target is supported Jesper Dangaard Brouer
2016-04-28 12:21 ` [net-next PATCH V4 3/5] samples/bpf: add a README file to get users started Jesper Dangaard Brouer
2016-04-28 13:37 ` Naveen N. Rao
2016-04-28 16:49 ` Alexei Starovoitov
2016-04-28 12:21 ` [net-next PATCH V4 4/5] samples/bpf: allow make to be run from samples/bpf/ directory Jesper Dangaard Brouer
2016-04-28 12:21 ` [net-next PATCH V4 5/5] samples/bpf: like LLC also verify and allow redefining CLANG command Jesper Dangaard Brouer
2016-04-29 18:26 ` [net-next PATCH V4 0/5] samples/bpf: Improve user experience David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428164046.0998f03d@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=borkmann@iogearbox.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).