From: David Miller <davem@davemloft.net>
To: kraigatgoog@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3 net] soreuseport: Fix TCP listener hash collision
Date: Sun, 01 May 2016 19:38:05 -0400 (EDT) [thread overview]
Message-ID: <20160501.193805.651325884144750958.davem@davemloft.net> (raw)
In-Reply-To: <1461885872-27358-1-git-send-email-kraigatgoog@gmail.com>
From: Craig Gallek <kraigatgoog@gmail.com>
Date: Thu, 28 Apr 2016 19:24:32 -0400
> From: Craig Gallek <kraig@google.com>
>
> I forgot to include a check for listener port equality when deciding
> if two sockets should belong to the same reuseport group. This was
> not caught previously because it's only necessary when two listening
> sockets for the same user happen to hash to the same listener bucket.
> The same error does not exist in the UDP path.
>
> Fixes: c125e80b8868("soreuseport: fast reuseport TCP socket selection")
> Signed-off-by: Craig Gallek <kraig@google.com>
Applied.
prev parent reply other threads:[~2016-05-01 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 23:24 [PATCH v3 net] soreuseport: Fix TCP listener hash collision Craig Gallek
2016-04-28 23:46 ` Eric Dumazet
2016-05-01 23:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501.193805.651325884144750958.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kraigatgoog@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).