From: Stephen Hemminger <stephen@networkplumber.org>
To: Quentin Monnet <quentin.monnet@6wind.com>
Cc: alexei.starovoitov@gmail.com, hadi@mojatatu.com,
netdev@vger.kernel.org, vincent.jardin@6wind.com
Subject: Re: [PATCH iproute2] tc: add bash-completion function
Date: Mon, 2 May 2016 15:14:14 -0700 [thread overview]
Message-ID: <20160502151414.0c9c3e3a@xeon-e3> (raw)
In-Reply-To: <1461918431-6518-1-git-send-email-quentin.monnet@6wind.com>
On Fri, 29 Apr 2016 10:27:11 +0200
Quentin Monnet <quentin.monnet@6wind.com> wrote:
> Add function for command completion for tc in bash, and update Makefile
> to install it:
>
> - Under /usr/share/bash-completion/completions/ (default).
> - Or under /etc/bash_completions.d/, which is the old directory for
> bash-completion, if /usr/share/bash-completion/completions/ is not
> found AND /etc/bash_completions.d/ exists already.
>
> Inside iproute2 repository, the completion code is in a new
> `bash-completion` toplevel directory.
>
> Signed-off-by: Quentin Monnet <quentin.monnet@6wind.com>
Rather than having an if statement in the install; lets follow how
other paths are handles.
* default value should be what current distros use /usr/share
* other distro's can override it with environment variable.
Something like:
Makefile:
PREFIX?=/usr
LIBDIR?=$(PREFIX)/lib
SBINDIR?=/sbin
CONFDIR?=/etc/iproute2
DATADIR?=$(PREFIX)/share
DOCDIR?=$(DATADIR)/doc/iproute2
MANDIR?=$(DATADIR)/man
ARPDDIR?=/var/lib/arpd
KERNEL_INCLUDE?=/usr/include
BASH_COMPDIR?=$(DATADIR)/bash-completion/completions/
next prev parent reply other threads:[~2016-05-02 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 7:28 iproute2: bash completion function for tc Quentin Monnet
2016-04-28 3:19 ` Alexei Starovoitov
2016-04-28 5:13 ` Stephen Hemminger
2016-04-28 12:15 ` Quentin Monnet
2016-04-28 16:53 ` Alexei Starovoitov
2016-04-29 8:27 ` [PATCH iproute2] tc: add bash-completion function Quentin Monnet
2016-05-02 22:14 ` Stephen Hemminger [this message]
2016-05-03 7:39 ` [PATCH iproute2 v2] " Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502151414.0c9c3e3a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexei.starovoitov@gmail.com \
--cc=hadi@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@6wind.com \
--cc=vincent.jardin@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).