Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

Wang Shanker
2016-05-03T02:40:53Z

[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]

Thanks a lot.

I feel it excited to contribute to the development of kernel. I’ll do
better next time.

> 在 2016年5月3日，06:19，Stephen Hemminger <stephen@networkplumber.org> 写道：
>
> On Thu, 28 Apr 2016 15:50:47 +0100
> James Chapman <jchapman@katalix.com> wrote:
>
>> Yes, that looks like the problem.
>>
>> The comments in l2tp.h which indicate that the csum attributes are u8
>> values are wrong. Code in net/l2tp/l2tp_netlink.c accesses these
>> attributes using nla_get_flag().
>>
>> Please submit a patch to fix l2tp_tunnel_sock_create(). Include good
>> change notes and your signed-off-by tag so that it gets reviewed. See
>> Documentation/SubmittingPatches if you haven't submitted a kernel
>> patch here before.
>
> Thank you for fixing this. James is is correct.
> Please format the patch according to the submission guidelines.
> For example, checkpatch complains about current patch.
>
> ERROR: code indent should use tabs where possible
> #156: FILE: net/l2tp/l2tp_core.c:1379:
> + ! cfg->udp6_zero_tx_checksums;$
>
> WARNING: please, no spaces at the start of a line
> #156: FILE: net/l2tp/l2tp_core.c:1379:
> + ! cfg->udp6_zero_tx_checksums;$
>
> ERROR: space prohibited after that '!' (ctx:ExW)
> #156: FILE: net/l2tp/l2tp_core.c:1379:
> + ! cfg->udp6_zero_tx_checksums;
> ^
>
> ERROR: code indent should use tabs where possible
> #159: FILE: net/l2tp/l2tp_core.c:1381:
> + ! cfg->udp6_zero_rx_checksums;$
>
> WARNING: please, no spaces at the start of a line
> #159: FILE: net/l2tp/l2tp_core.c:1381:
> + ! cfg->udp6_zero_rx_checksums;$
>
> ERROR: space prohibited after that '!' (ctx:ExW)
> #159: FILE: net/l2tp/l2tp_core.c:1381:
> + ! cfg->udp6_zero_rx_checksums;
> ^
>
> ERROR: Missing Signed-off-by: line(s)
>
>
> I am sorry that maintainers may seem like picky teachers in school
> always putting redline around spelling errors, but this is how we work to teach
> others how to follow the process.
>

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4130 bytes --]