* [PATCH] drivers: net: xgene: constify xgene_cle_ops structure
@ 2016-05-01 12:36 Julia Lawall
2016-05-01 23:10 ` Iyappan Subramanian
2016-05-03 17:03 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2016-05-01 12:36 UTC (permalink / raw)
To: Iyappan Subramanian; +Cc: kernel-janitors, Keyur Chudgar, netdev, linux-kernel
The xgene_cle_ops structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 2 +-
drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 +-
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c
index b2124886..6479288 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c
@@ -729,6 +729,6 @@ static int xgene_enet_cle_init(struct xgene_enet_pdata *pdata)
return xgene_cle_setup_ptree(pdata, enet_cle);
}
-struct xgene_cle_ops xgene_cle3in_ops = {
+const struct xgene_cle_ops xgene_cle3in_ops = {
.cle_init = xgene_enet_cle_init,
};
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h
index 29a17ab..13e829a 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h
@@ -290,6 +290,6 @@ struct xgene_enet_cle {
u32 jump_bytes;
};
-extern struct xgene_cle_ops xgene_cle3in_ops;
+extern const struct xgene_cle_ops xgene_cle3in_ops;
#endif /* __XGENE_ENET_CLE_H__ */
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.h b/drivers/net/ethernet/apm/xgene/xgene_enet_main.h
index 175d188..0a2887b 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.h
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.h
@@ -191,7 +191,7 @@ struct xgene_enet_pdata {
const struct xgene_mac_ops *mac_ops;
const struct xgene_port_ops *port_ops;
struct xgene_ring_ops *ring_ops;
- struct xgene_cle_ops *cle_ops;
+ const struct xgene_cle_ops *cle_ops;
struct delayed_work link_work;
u32 port_id;
u8 cpu_bufnum;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: net: xgene: constify xgene_cle_ops structure
2016-05-01 12:36 [PATCH] drivers: net: xgene: constify xgene_cle_ops structure Julia Lawall
@ 2016-05-01 23:10 ` Iyappan Subramanian
2016-05-03 17:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Iyappan Subramanian @ 2016-05-01 23:10 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Keyur Chudgar, netdev,
linux-kernel@vger.kernel.org
On Sun, May 1, 2016 at 5:36 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> The xgene_cle_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 2 +-
> drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 +-
> drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c
> index b2124886..6479288 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.c
> @@ -729,6 +729,6 @@ static int xgene_enet_cle_init(struct xgene_enet_pdata *pdata)
> return xgene_cle_setup_ptree(pdata, enet_cle);
> }
>
> -struct xgene_cle_ops xgene_cle3in_ops = {
> +const struct xgene_cle_ops xgene_cle3in_ops = {
> .cle_init = xgene_enet_cle_init,
> };
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h
> index 29a17ab..13e829a 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_cle.h
> @@ -290,6 +290,6 @@ struct xgene_enet_cle {
> u32 jump_bytes;
> };
>
> -extern struct xgene_cle_ops xgene_cle3in_ops;
> +extern const struct xgene_cle_ops xgene_cle3in_ops;
>
> #endif /* __XGENE_ENET_CLE_H__ */
> diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.h b/drivers/net/ethernet/apm/xgene/xgene_enet_main.h
> index 175d188..0a2887b 100644
> --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.h
> +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.h
> @@ -191,7 +191,7 @@ struct xgene_enet_pdata {
> const struct xgene_mac_ops *mac_ops;
> const struct xgene_port_ops *port_ops;
> struct xgene_ring_ops *ring_ops;
> - struct xgene_cle_ops *cle_ops;
> + const struct xgene_cle_ops *cle_ops;
> struct delayed_work link_work;
> u32 port_id;
> u8 cpu_bufnum;
>
Thanks Julia.
Acked-by: Iyappan Subramanian <isubramanian@apm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: net: xgene: constify xgene_cle_ops structure
2016-05-01 12:36 [PATCH] drivers: net: xgene: constify xgene_cle_ops structure Julia Lawall
2016-05-01 23:10 ` Iyappan Subramanian
@ 2016-05-03 17:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-03 17:03 UTC (permalink / raw)
To: Julia.Lawall
Cc: isubramanian, kernel-janitors, kchudgar, netdev, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 1 May 2016 14:36:28 +0200
> The xgene_cle_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-03 17:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-01 12:36 [PATCH] drivers: net: xgene: constify xgene_cle_ops structure Julia Lawall
2016-05-01 23:10 ` Iyappan Subramanian
2016-05-03 17:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).