From: David Miller <davem@davemloft.net>
To: anna-maria@linutronix.de
Cc: linux-kernel@vger.kernel.org, rt@linutronix.de,
thomas.petazzoni@free-electrons.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call
Date: Tue, 03 May 2016 15:28:06 -0400 (EDT) [thread overview]
Message-ID: <20160503.152806.1985815306043431466.davem@davemloft.net> (raw)
In-Reply-To: <1462179771-55875-1-git-send-email-anna-maria@linutronix.de>
From: Anna-Maria Gleixner <anna-maria@linutronix.de>
Date: Mon, 2 May 2016 11:02:51 +0200
> Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out
> in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call to
> mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
> not require to be called with interrupts disabled, therefore the
> smp_call_function_single() calling convention is not preserved.
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Applied, thanks.
prev parent reply other threads:[~2016-05-03 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 9:02 [PATCH v2] net: mvneta: Remove superfluous SMP function call Anna-Maria Gleixner
2016-05-03 19:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503.152806.1985815306043431466.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox