From: David Miller <davem@davemloft.net>
To: weiwan@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] ipv6: add new struct ipcm6_cookie
Date: Tue, 03 May 2016 16:20:01 -0400 (EDT) [thread overview]
Message-ID: <20160503.162001.2049403211410235502.davem@davemloft.net> (raw)
In-Reply-To: <1462250407-19496-1-git-send-email-tracywwnj@gmail.com>
From: Wei Wang <weiwan@google.com>
Date: Mon, 2 May 2016 21:40:07 -0700
> From: Wei Wang <weiwan@google.com>
>
> In the sendmsg function of UDP, raw, ICMP and l2tp sockets, we use local
> variables like hlimits, tclass, opt and dontfrag and pass them to corresponding
> functions like ip6_make_skb, ip6_append_data and xxx_push_pending_frames.
> This is not a good practice and makes it hard to add new parameters.
> This fix introduces a new struct ipcm6_cookie similar to ipcm_cookie in
> ipv4 and include the above mentioned variables. And we only pass the
> pointer to this structure to corresponding functions. This makes it easier
> to add new parameters in the future and makes the function cleaner.
>
> Signed-off-by: Wei Wang <weiwan@google.com>
Applied, thanks.
prev parent reply other threads:[~2016-05-03 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 4:40 [PATCH net-next v2] ipv6: add new struct ipcm6_cookie Wei Wang
2016-05-03 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503.162001.2049403211410235502.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).