From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nf-next 0/9] netfilter: remove per-netns conntrack tables, part 1 Date: Wed, 4 May 2016 00:30:03 +0200 Message-ID: <20160503223003.GC1196@salvia> References: <1461863628-23350-1-git-send-email-fw@strlen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org To: Florian Westphal Return-path: Received: from mail.us.es ([193.147.175.20]:47946 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756519AbcECWaI (ORCPT ); Tue, 3 May 2016 18:30:08 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 37781EAA89 for ; Wed, 4 May 2016 00:30:07 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2934D64469 for ; Wed, 4 May 2016 00:30:07 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A9F11A868 for ; Wed, 4 May 2016 00:30:04 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1461863628-23350-1-git-send-email-fw@strlen.de> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Apr 28, 2016 at 07:13:39PM +0200, Florian Westphal wrote: > [ CCing netdev so netns folks can have a look too ] > > This patch series removes the per-netns connection tracking tables. > All conntrack objects are then stored in one global global table. > > This avoids the infamous 'vmalloc' when lots of namespaces are used: > We no longer allocate a new conntrack table for each namespace (with 64k > size this saves 512kb of memory per netns). > > - net namespace address is made part of conntrack hash, to spread > conntracks over entire table even if netns has overlapping ip addresses. > - lookup and iterators net_eq() to skip conntracks living in a different > namespace. > > Only the main conntrack table is converted here: > NAT bysrc and expectation hashes are still per namespace (will be unified > in a followup series). Also, this retains the per-namespace kmem cache > for the conntrack objects. This will also be resolved in a followup series. This rework in important, I'm going to place this batch in the tree so you can keep working on this. Thanks.