From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()
Date: Wed, 04 May 2016 12:47:12 -0400 (EDT)
Message-ID: <20160504.124712.1261854747800227136.davem@davemloft.net>
References: <20160503.120556.1317913903199470646.davem@davemloft.net>
	<20160504090529.GJ16459@soda.linbit>
	<5729EFBC.7040002@6wind.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: netdev@vger.kernel.org, philipp.reisner@linbit.com,
	drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
To: nicolas.dichtel@6wind.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <5729EFBC.7040002@6wind.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

=46rom: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 4 May 2016 14:49:00 +0200

> Le 04/05/2016 11:05, Lars Ellenberg a =E9crit :
> [snip]
>> We don't have an "alignment problem" there, btw.
>> Last time I checked, we did work fine without this alignment magic,
>> we already take care of that, yes, even on affected architectures.
> The code adds several consecutive u64 attributes. The nl attribute he=
ader is 4
> bytes, thus the full attribute length is 12 bytes. If the first u64 i=
s aligned
> on 8 (nla_data()), the next one is not aligned on 8: it starts 12 byt=
es (8 (u64)
> + 4 (nl attr hdr)) after the previous u64.

Right.