From: David Miller <davem@davemloft.net>
To: u.kleine-koenig@pengutronix.de
Cc: fugang.duan@nxp.com, kernel@pengutronix.de, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fec: only clear a queue's work bit if the queue was emptied
Date: Wed, 04 May 2016 14:09:10 -0400 (EDT) [thread overview]
Message-ID: <20160504.140910.2171362814117515274.davem@davemloft.net> (raw)
In-Reply-To: <1462286333-23402-1-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Tue, 3 May 2016 16:38:53 +0200
> In the receive path a queue's work bit was cleared unconditionally even
> if fec_enet_rx_queue only read out a part of the available packets from
> the hardware. This resulted in not reading any packets in the next napi
> turn and so packets were delayed or lost.
>
> The obvious fix is to only clear a queue's bit when the queue was
> emptied.
>
> Fixes: 4d494cdc92b3 ("net: fec: change data structure to support multiqueue")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-05-04 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 14:38 [PATCH] net: fec: only clear a queue's work bit if the queue was emptied Uwe Kleine-König
2016-05-03 14:42 ` Lucas Stach
2016-05-04 2:12 ` Fugang Duan
2016-05-04 18:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504.140910.2171362814117515274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).