netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: pull request (net): ipsec 2016-05-04
Date: Wed, 04 May 2016 16:48:28 -0400 (EDT)	[thread overview]
Message-ID: <20160504.164828.439672981604295842.davem@davemloft.net> (raw)
In-Reply-To: <1462340454-27922-1-git-send-email-steffen.klassert@secunet.com>

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Wed, 4 May 2016 07:40:51 +0200

> 1) The flowcache can hit an OOM condition if too
>    many entries are in the gc_list. Fix this by
>    counting the entries in the gc_list and refuse
>    new allocations if the value is too high.
> 
> 2) The inner headers are invalid after a xfrm transformation,
>    so reset the skb encapsulation field to ensure nobody tries
>    access the inner headers. Otherwise tunnel devices stacked
>    on top of xfrm may build the outer headers based on wrong
>    informations.
> 
> 3) Add pmtu handling to vti, we need it to report
>    pmtu informations for local generated packets.
> 
> Please pull or let me know if there are problems.

Pulled, thanks Steffen.

While build testing this I was worried that it might be possible
to create a situation where IP_VTI=y yet IPV6=m and therefore have
a unresolvable reference to icmpv6_send().

However I was not able to create such a configuration, as hard as
I tried. :-)

      parent reply	other threads:[~2016-05-04 20:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  5:40 pull request (net): ipsec 2016-05-04 Steffen Klassert
2016-05-04  5:40 ` [PATCH 1/3] flowcache: Avoid OOM condition under preasure Steffen Klassert
2016-05-04  5:40 ` [PATCH 2/3] xfrm: Reset encapsulation field of the skb before transformation Steffen Klassert
2016-05-04  5:40 ` [PATCH 3/3] vti: Add pmtu handling to vti_xmit Steffen Klassert
2016-05-04 20:48 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160504.164828.439672981604295842.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).