From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATC net-next] tcp: must block bh in __inet_twsk_hashdance() Date: Wed, 04 May 2016 17:06:41 -0400 (EDT) Message-ID: <20160504.170641.134283593327091145.davem@davemloft.net> References: <1462320650.5535.334.camel@edumazet-glaptop3.roam.corp.google.com> <20160504.005450.32648328658519474.davem@davemloft.net> <1462386131.5535.353.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:43489 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100AbcEDVGp (ORCPT ); Wed, 4 May 2016 17:06:45 -0400 In-Reply-To: <1462386131.5535.353.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Wed, 04 May 2016 11:22:11 -0700 > On Wed, 2016-05-04 at 00:54 -0400, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 03 May 2016 17:10:50 -0700 >> >> > From: Eric Dumazet >> > >> > __inet_twsk_hashdance() might be called from process context, >> > better block BH before acquiring bind hash and established locks >> > >> > Fixes: c10d9310edf5 ("tcp: do not assume TCP code is non preemptible") >> > Signed-off-by: Eric Dumazet >> >> Applied. > > David, I do not see these two patches in net-next ? > > (This one, and the "tcp: fix lockdep splat in tcp_snd_una_update()" one) I pushed them in by hand, they should really be there now. Thanks for letting me know.