From: David Miller <davem@davemloft.net>
To: marc@arista.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [PATCH net-next v2] macvtap: add namespace support to the sysfs device class
Date: Wed, 04 May 2016 23:53:08 -0400 (EDT) [thread overview]
Message-ID: <20160504.235308.1088954708869507214.davem@davemloft.net> (raw)
In-Reply-To: <CAPSAET_zPYBvMdTQ5m1O9xO178Jk0b93rC1cy0CNY2yinUbnXw@mail.gmail.com>
From: Marc Angel <marc@arista.com>
Date: Thu, 5 May 2016 01:33:09 +0100
> On Wed, May 4, 2016 at 9:04 PM, David Miller <davem@davemloft.net> wrote:
>> From: Marc Angel <marc@arista.com>
>> Date: Tue, 3 May 2016 20:30:54 +0200
>>
>>> @@ -1274,6 +1285,7 @@ static int macvtap_device_event(struct notifier_block *unused,
>>> unsigned long event, void *ptr)
>>> {
>>> struct net_device *dev = netdev_notifier_info_to_dev(ptr);
>>> + const char *tap_name = kasprintf(GFP_KERNEL, "tap%d", dev->ifindex);
>>> struct macvlan_dev *vlan;
>>> struct device *classdev;
>>> dev_t devt;
>>
>> This 'tap_name' buffer seems to be leaked in several code paths.
>
> Sorry about that... V3 should be better.
V3 doesn't apply cleanly to net-next, please respin your patch against
the current tree.
Thanks.
next prev parent reply other threads:[~2016-05-05 3:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 14:11 [PATCH net-next] macvtap: add namespace support to the sysfs device class Marc Angel
2016-04-24 18:14 ` David Miller
2016-04-25 19:12 ` Eric W. Biederman
2016-04-28 16:35 ` Marc Angel
2016-05-03 18:30 ` [PATCH net-next v2] " Marc Angel
2016-05-04 20:04 ` David Miller
2016-05-05 0:33 ` Marc Angel
2016-05-05 3:53 ` David Miller [this message]
2016-05-05 10:12 ` Marc Angel
2016-05-05 10:14 ` [PATCH net-next v4] " Marc Angel
2016-05-05 21:23 ` David Miller
2016-05-05 0:34 ` [PATCH net-next v3] " Marc Angel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504.235308.1088954708869507214.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=marc@arista.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).