From: Andrew Lunn <andrew@lunn.ch>
To: John Crispin <john@phrozen.org>
Cc: "David S. Miller" <davem@davemloft.net>,
nbd@nbd.name, netdev@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] net-next: mediatek: add fixed-phy support
Date: Thu, 5 May 2016 14:02:53 +0200 [thread overview]
Message-ID: <20160505120253.GD7972@lunn.ch> (raw)
In-Reply-To: <1462439856-51788-3-git-send-email-john@phrozen.org>
On Thu, May 05, 2016 at 11:17:35AM +0200, John Crispin wrote:
> The MT7623 SoC has a builtin gigabit switch. If we want to use it, GMAC1
> needs to be configured using a fixed link speed and flow control settings.
> The easiest way to do this is to used the fixed-phy driver, allowing us to
> reuse the existing mdio polling code to setup the MAC.
>
> Signed-off-by: John Crispin <john@phrozen.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Looks good.
Andrew
next prev parent reply other threads:[~2016-05-05 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 9:17 [PATCH 0/3] net-next: mediatek: improve phy support John Crispin
[not found] ` <1462439856-51788-1-git-send-email-john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>
2016-05-05 9:17 ` [PATCH 1/3] net-next: mediatek: fix gigabit and flow control advertisement John Crispin
2016-05-05 9:17 ` [PATCH 2/3] net-next: mediatek: add fixed-phy support John Crispin
2016-05-05 12:02 ` Andrew Lunn [this message]
2016-05-05 9:17 ` [PATCH 3/3] net-next: mediatek: add RX delay support John Crispin
2016-05-05 12:13 ` Andrew Lunn
2016-05-05 17:37 ` John Crispin
2016-05-05 21:20 ` [PATCH 0/3] net-next: mediatek: improve phy support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505120253.GD7972@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).