* [patch] netxen: netxen_rom_fast_read() doesn't return -1
@ 2016-05-05 13:20 Dan Carpenter
2016-05-07 19:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-05 13:20 UTC (permalink / raw)
To: Manish Chopra
Cc: Sony Chacko, Rajesh Borundia, netdev, linux-kernel,
kernel-janitors
The error handling is broken here. netxen_rom_fast_read() returns zero
on success and -EIO on error. It never returns -1.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index fd362b6..9c6eed9 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -852,7 +852,8 @@ netxen_check_options(struct netxen_adapter *adapter)
ptr32 = (__le32 *)&serial_num;
offset = NX_FW_SERIAL_NUM_OFFSET;
for (i = 0; i < 8; i++) {
- if (netxen_rom_fast_read(adapter, offset, &val) == -1) {
+ err = netxen_rom_fast_read(adapter, offset, &val);
+ if (err) {
dev_err(&pdev->dev, "error reading board info\n");
adapter->driver_mismatch = 1;
return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] netxen: netxen_rom_fast_read() doesn't return -1
2016-05-05 13:20 [patch] netxen: netxen_rom_fast_read() doesn't return -1 Dan Carpenter
@ 2016-05-07 19:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-07 19:16 UTC (permalink / raw)
To: dan.carpenter
Cc: manish.chopra, sony.chacko, rajesh.borundia, netdev, linux-kernel,
kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 5 May 2016 16:20:20 +0300
> The error handling is broken here. netxen_rom_fast_read() returns zero
> on success and -EIO on error. It never returns -1.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-07 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-05 13:20 [patch] netxen: netxen_rom_fast_read() doesn't return -1 Dan Carpenter
2016-05-07 19:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).